Subject: Re: [PATCH 5/7] vcs-svn: extend svndump to parse version 3 format

From: Jonathan Nieder <[email-masked]>
Date: Tue, 12 Oct 2010 17:56:46 -0500

David Barr wrote:

> Added 1 new dump header, SVN-fs-dump-format-version.
> Added 6 new node headers:

Style: using the imperative mood, present tense would make this
fit better with other log entries.

> --- a/vcs-svn/svndump.c
> +++ b/vcs-svn/svndump.c
> @@ -27,6 +27,9 @@
>  #define LENGTH_UNKNOWN (~0)
>  #define DATE_RFC2822_LEN 31
>  
> +#define MD5_HEX_LENGTH 32
> +#define SHA1_HEX_LENGTH 40

I was surprised to find this is not in any existing header.  Looks
good to me.