Subject: Re: [PATCH v2 7/8] t5523-push-upstream: test progress messages

From: Jonathan Nieder <[email-masked]>
Date: Sat, 16 Oct 2010 19:46:13 -0500

Tay Ray Chuan wrote:

[...]
> --- a/t/t5523-push-upstream.sh
> +++ b/t/t5523-push-upstream.sh
> @@ -70,4 +71,41 @@ test_expect_success 'push -u HEAD' '
>  	check_config headbranch upstream refs/heads/headbranch
>  '
>  
> +test_expect_success TTY 'progress messages go to tty' '
> +	ensure_fresh_upstream &&
> +
> +	test_terminal git push -u upstream master >out 2>err &&
> +	grep "Writing objects" err
> +'

Thanks for testing the usual case.  It is easy to forget sometimes.

The tests using the TTY prerequisite would need to use TTYREDIR
unless we simplify the latter out of existence.