Subject: Re: [PATCH 2/3] config: add git_config_from_sha1() to read from a blob

From: Jonathan Nieder <[email-masked]>
Date: Thu, 9 Dec 2010 11:02:28 -0600

Thiago Farina wrote:
> 2010/12/9 Nguyễn Thái Ngọc Duy <[email-masked]>:

>> +static int git_config_from_sha1(config_fn_t fn, const char *sha1_name, void *data)
>> +{
>
> Is worth documenting the return value of this function and what it
> does? It returns 0 on success otherwise returns -1.

If that is the return value, then no.  It is the usual in git (and
other C programs that follow libc conventions).