public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt•net>
To: Jakub Narebski <jnareb@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 4/4] git-instaweb: Use "git-instaweb" as sitename (for page titles)
Date: Thu, 30 Dec 2010 06:23:29 +0000	[thread overview]
Message-ID: <20101230062329.GD16090@dcvr.yhbt.net> (raw)
In-Reply-To: <201012291750.09610.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail•com> wrote:
> This is new feature, and doesn't need to be in 1.7.4
> 
> It would be an RFC, if not for the fact that it is such trivial change.

Thanks Jakub.  This series all looks reasonable to me (untested).

      reply	other threads:[~2010-12-30  6:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-29 16:43 [PATCH 0/4] git-instaweb: Three fixes and one improvement Jakub Narebski
2010-12-29 16:47 ` [BUGFIX PATCH 1/4] git-instaweb: Fix issue with static files for 'plackup' server Jakub Narebski
2010-12-29 23:24   ` Junio C Hamano
2010-12-29 23:52   ` Junio C Hamano
2010-12-30  0:40     ` Jakub Narebski
2010-12-29 16:48 ` [PATCH 2/4] git-instaweb: Static files are under "static/" in gitweb_conf Jakub Narebski
2010-12-29 16:49 ` [PATCH 3/4] git-instaweb: Add checks that web server can be started and is started Jakub Narebski
2010-12-29 16:50 ` [PATCH 4/4] git-instaweb: Use "git-instaweb" as sitename (for page titles) Jakub Narebski
2010-12-30  6:23   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101230062329.GD16090@dcvr.yhbt.net \
    --to=normalperson@yhbt$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jnareb@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox