public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Libor Pechacek <lpechacek@suse•cz>
To: git@vger•kernel.org
Subject: git-config does not check validity of variable names
Date: Sat, 8 Jan 2011 15:46:44 +0100	[thread overview]
Message-ID: <20110108144644.GA11019@localhost.suse.cz> (raw)

Hello,

I've noticed that git-config accepts variable names in the form "a=b" for its
"get" operation.  That means "git config a=b" does not write anything to its
output and exists with status 1.

According to the man page only alphanumeric characters and - are allowed in
variable names.  Would it make sense to spit out an error message when the user
supplies an invalid variable name like the above?

Libor
-- 
Libor Pechacek
SUSE L3 Team, Prague

             reply	other threads:[~2011-01-08 14:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-08 14:46 Libor Pechacek [this message]
2011-01-11  5:59 ` git-config does not check validity of variable names Jeff King
2011-01-19 10:01   ` Libor Pechacek
2011-01-19 14:11     ` [PATCH] Sanity-ckeck config " Libor Pechacek
2011-01-20 23:22       ` Jeff King
2011-01-21  0:06         ` Jeff King
2011-01-21 10:02         ` Libor Pechacek
2011-01-21 10:23           ` [PATCH v2] " Libor Pechacek
2011-01-21 16:23             ` Jeff King
2011-01-27 14:28               ` [PATCH v3] Sanity-check " Libor Pechacek
2011-01-27 22:45                 ` Junio C Hamano
2011-01-28 14:53                   ` Libor Pechacek
2011-01-30 19:40                     ` [PATCH v4] " Libor Pechacek
2011-02-10 22:49                       ` Junio C Hamano
2011-02-11 18:52                         ` Libor Pechacek
2011-01-19 14:14     ` [PATCH] Documentation fixes in git-config Libor Pechacek
2011-01-21  0:27       ` Jeff King
2011-01-21 10:20         ` Libor Pechacek
2011-01-21 10:25           ` [PATCH v2] " Libor Pechacek
2011-01-21 16:25             ` Jeff King
2011-01-23 19:46               ` Libor Pechacek
2012-03-01  8:19             ` [PATCH v3] " Libor Pechacek
2012-03-01  9:08               ` Jeff King
2012-03-01 10:54                 ` Libor Pechacek
2012-03-01 16:24                 ` Junio C Hamano
2012-03-01 10:59               ` [PATCH v4] " Libor Pechacek
2011-01-27 14:52 ` [PATCH] Disallow empty section and variable names Libor Pechacek
2011-01-30 20:34   ` [PATCH v2] " Libor Pechacek
2011-01-31  7:48     ` Johannes Sixt
2011-01-31  9:17       ` Libor Pechacek
2011-01-31  9:29         ` Johannes Sixt
2011-01-31 13:08           ` [PATCH v3] " Libor Pechacek
2011-01-31 16:48             ` Jens Lehmann
2011-02-01  7:13               ` [PATCH v4] " Libor Pechacek
2011-02-10 22:49                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110108144644.GA11019@localhost.suse.cz \
    --to=lpechacek@suse$(echo .)cz \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox