Subject: Re: [PATCH v4 64/73] gettextize: git-describe basic messages

From: Jakub Narebski <[email-masked]>
Date: Sat, 26 Feb 2011 10:55:55 +0100

On Wed, 23 Feb 2011, Ævar Arnfjörð Bjarmason wrote:

>                 if (strcmp(n->tag->tag, all ? n->path + 5 : n->path))
> -                       warning("tag '%s' is really '%s' here", n->tag->tag, n->path);
> +                       warning(_("tag '%s' is really '%s' here"), n->tag->tag, n->path);
>                 n->name_checked = 1;
>         }

Don't we need to use order notation to be able to change order of those
two parameters, i.e. use

  +                       warning(_("tag '%1$s' is really '%2$s' here"), n->tag->tag, n->path);

Perhaps also some comment for translators describing placeholders?

-- 
Jakub Narebski
Poland