Subject: Re: [PATCH] Test failure when spaces in git root

From: Thomas Rast <[email-masked]>
Date: Thu, 24 Mar 2011 21:46:02 +0100

Carl Michael Skog wrote:
> Some of the svn related tests would break when the git root path had
> spaces in it.
[...]
> -quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/')"
> +quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/g')"

If you're already fixing this, shouldn't it be

  $(echo "$svnrepo" | ...)

to stop the expansion process from converting arbitrary series of
whitespace into a single space?

However, any other (than space) character that needs %-quoting would
probably also break the test.  Maybe some more complicated mangling
would be in order.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch