From: Jakub Narebski <jnareb@gmail•com>
To: "Øyvind A. Holm" <sunny@sunbase•org>
Cc: Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org,
"John 'Warthog9' Hawley" <warthog9@eaglescrag•net>,
"John 'Warthog9' Hawley" <warthog9@kernel•org>,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix•de>,
Jonathan Nieder <jrnieder@gmail•com>, Petr Baudis <pasky@suse•cz>,
Sebastien Cevey <seb@cine7•net>,
Greg Kroah-Hartman <greg@kroah•com>,
Ryan Anderson <ryan@michonline•com>
Subject: Re: git-send-email and non 7bit clean message (was: [PATCH 0/6] gitweb: Improve ctags, introduce categories)
Date: Tue, 3 May 2011 16:02:28 +0200 [thread overview]
Message-ID: <201105031602.30874.jnareb@gmail.com> (raw)
In-Reply-To: <BANLkTi=cckKr3baDZAktAjz8F=JXjQJWiA@mail.gmail.com>
On Sat, 30 Apr 2011, Øyvind A. Holm wrote:
> On 29 April 2011 23:31, Junio C Hamano <gitster@pobox•com> wrote:
> > A tangent. It is curious why [PATCH 2/6] alone ended up with an encoded
> > "Subject" header, like this:
> >
> > Subject: =?UTF-8?q?=5BPATCH=202/6=5D=20gitweb=3A=20Change=20the=20
> > way=20=22content=20tags=22=20=28=27ctags=27=29=20are=20handled?=
> >
> > The message actually has the above as a long single line, as can be seen at
> > http://article.gmane.org/gmane.comp.version-control.git/172479/raw
> >
> > Just being curious.
>
> This seems as the same thing that I reported on 2010-04-25 23:35:49Z,
> <http://thread.gmane.org/gmane.comp.version-control.git/145774>. If there's a
> character above U+007F in the log message below line #2, the Subject: line is
> garbled. In this case it is, it's the "ö" in Uwe's name that leads to this
> error.
>
> A test to reproduce this is at <https://gist.github.com/378785>, but it seems
> as this was fixed between v1.7.4.1-292-ge2a57aa and v1.7.4.1-343-ga91df69 ,
> probably happened in dc7f96f (Merge branch 'jk/format-patch-multiline-header').
> The patch at <http://article.gmane.org/gmane.comp.version-control.git/172479/raw>
> was generated with git-1.7.3, so it would trigger the error in this case.
I have just upgraded git to 1.7.5, and unfortunately it still has the
same bug (note that UTF-8 character was introduced while editing patch,
so git-format-patch doesn't see it):
5369:[gitweb/web@git]# git send-email [...] --dry-run mdir.1/*.txt
The following files are 8bit, but do not declare a Content-Transfer-Encoding.
mdir.1/0001-gitweb-Prepare-for-splitting-gitweb.txt
Which 8bit encoding should I declare [UTF-8]? <ENTER>
Dry-Sent [PATCHv2 0/2] gitweb: Beginnings of splitting gitweb into modules
Dry-Sent =?UTF-8?q?=5BPATCHv2=201/2=20=28RFC=3F=29=5D=20gitweb=3A=20Prepare=20for=20splitting=20gitweb?=
Dry-Sent [PATCHv2 2/2 (PoC)] gitweb: Create Gitweb::Util module
Note that having
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
is not enough[1]. However the patch send is understood correctly by email
programs: see [PATCH 2/6] in this thread.
I have added
Content-Transfer-Encoding: 8bit
to mdir.1/0001-gitweb-Prepare-for-splitting-gitweb.txt, and now it works
all right.
5370:[gitweb/web@git]# git send-email [...] mdir.1/*.txt
Dry-Sent [PATCHv2 0/2] gitweb: Beginnings of splitting gitweb into modules
Dry-Sent [PATCHv2 1/2 (RFC?)] gitweb: Prepare for splitting gitweb
Dry-Sent [PATCHv2 2/2 (PoC)] gitweb: Create Gitweb::Util module
Footnotes:
^^^^^^^^^^
[1]: Note that git-send-email does something strange: first, the problem
is with Content-Transfer-Encoding, and git-send-email asks for 8bit
encoding, suggesting UTF-8, instead of asking for transfer encoding,
sugesting e.g. 8bit.
Second, from email headers I have added git-send-email should _know_ that
message uses UTF-8 encoding (though this is side issue, and probably result
of above).
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2011-05-03 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 17:51 [PATCH 0/6] gitweb: Improve ctags, introduce categories Jakub Narebski
2011-04-29 17:51 ` [PATCH 1/6 (v2)] gitweb: Restructure projects list generation Jakub Narebski
2011-05-07 18:39 ` Jakub Narebski
2011-04-29 17:51 ` [PATCH 2/6] gitweb: Change the way "content tags" ('ctags') are handled Jakub Narebski
2011-04-29 17:51 ` [PATCH 3/6] gitweb: Mark matched 'ctag' / contents tag (?by_tag=foo) Jakub Narebski
2011-04-29 17:51 ` [PATCH 4/6] gitweb: Split git_project_list_body in two functions Jakub Narebski
2011-04-29 17:52 ` [PATCH 5/6] gitweb: Modularized git_get_project_description to be more generic Jakub Narebski
2011-04-29 17:52 ` [PATCH 6/6] gitweb: Optional grouping of projects by category Jakub Narebski
2011-04-29 21:31 ` [PATCH 0/6] gitweb: Improve ctags, introduce categories Junio C Hamano
2011-04-29 23:53 ` Jakub Narebski
2011-04-30 20:36 ` Øyvind A. Holm
2011-05-03 14:02 ` Jakub Narebski [this message]
2011-05-04 13:50 ` [PATCH/RFC] git-send-email: Do not encode Subject if not required (was: git-send-email and non 7bit clean message) Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105031602.30874.jnareb@gmail.com \
--to=jnareb@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=pasky@suse$(echo .)cz \
--cc=ryan@michonline$(echo .)com \
--cc=seb@cine7$(echo .)net \
--cc=sunny@sunbase$(echo .)org \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=warthog9@eaglescrag$(echo .)net \
--cc=warthog9@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox