public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Pete Wyckoff <pw@padd•com>
To: Luke Diamand <luke@diamand•org>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH v3] git-p4: add option to preserve user names
Date: Fri, 6 May 2011 19:59:12 -0400	[thread overview]
Message-ID: <20110506235912.GA11842@arf.padd.com> (raw)
In-Reply-To: <4DC38657.7020703@diamand.org>

luke@diamand•org wrote on Fri, 06 May 2011 06:25 +0100:
> On 06/05/11 06:07, Junio C Hamano wrote:
> >Luke Diamand<luke@diamand•org>  writes:
> >
> >>This is version 3 of my patch.
> >
> >The previous one from Apr 21st is already on "next" with Ack from Pete.
> 
> Ah, sorry.
> 
> Should I submit a patch against that then?

Yes, your changes look good and fix bugs.

To the diff from v2 to v3:

Acked-by: Pete Wyckoff <pw@padd•com>


		-- Pete

  reply	other threads:[~2011-05-06 23:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-05  6:43 [PATCH v3] git-p4: add option to preserve user names Luke Diamand
2011-05-05  6:43 ` Luke Diamand
2011-05-06  5:07 ` Junio C Hamano
2011-05-06  5:25   ` Luke Diamand
2011-05-06 23:59     ` Pete Wyckoff [this message]
2011-05-07 22:22       ` Junio C Hamano
2011-05-08 10:58         ` Luke Diamand
2011-05-08 17:32           ` Junio C Hamano
2011-05-08 20:35             ` Luke Diamand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110506235912.GA11842@arf.padd.com \
    --to=pw@padd$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=luke@diamand$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox