Subject: Re: [PATCH v4 (for maint)] git-completion: fix zsh support

From: Jonathan Nieder <[email-masked]>
Date: Mon, 9 May 2011 17:53:07 -0500

Felipe Contreras wrote:

> v4: more commit message improvements

Thanks.  You seem to have ignored most of my review; I'll try to find
time to clarify the commit message if the consensus is that this
approach is a good idea.

An alternative possibility if we need this fixed in the v1.7.5.x
series (do we?) would be cherry-picking the fix from
sg/completion-updates on top of maint.

To clarify the trade-offs:

 - in terms of lines of code, the fix itself in sg/completion-updates
   and this fix are about the same size.  But the sg/completion-updates
   version relies on a code cleanup.

 - the fix in sg/completion-updates is less likely to be broken by
   future changes in the bashcompinit library.

 - this fix is conceptually simpler.  In a way, the fix in
   sg/completion-updates only works by accident.