Subject: Re: [PATCH 2/6] Factorize shortening of notes refname for display.

From: Johan Herland <[email-masked]>
Date: Sun, 19 Jun 2011 23:25:00 +0200

On Saturday 18 June 2011, Yann Dirson wrote:
> Signed-off-by: Yann Dirson <[email-masked]>
> ---
>  notes.c |   24 ++++++++++++++++--------
>  notes.h |    7 +++++++
>  2 files changed, 23 insertions(+), 8 deletions(-)
> 
> [...]
> 
>  /*
> + * Return a short name for a notes ref, suitable for display to the user.
> + *
> + * No copy is done, the return value is a pointer into the original string.
> + */
> +const char *notes_ref_shortname(const char *ref);
> +
> +/*

Please include in the documentation what a NULL return means.

Otherwise the patch looks OK.

...Johan

-- 
Johan Herland, <[email-masked]>
www.herland.net