Subject: Re: [PATCH 2/6] Factorize shortening of notes refname for display.

From: Yann Dirson <[email-masked]>
Date: Mon, 20 Jun 2011 20:49:53 +0200

On Sun, Jun 19, 2011 at 03:51:34PM -0700, Junio C Hamano wrote:
> Johan Herland <[email-masked]> writes:
> 
> > On Saturday 18 June 2011, Yann Dirson wrote:
> >> Signed-off-by: Yann Dirson <[email-masked]>
> >> ---
> >>  notes.c |   24 ++++++++++++++++--------
> >>  notes.h |    7 +++++++
> >>  2 files changed, 23 insertions(+), 8 deletions(-)
> >> 
> >> [...]
> >> 
> >>  /*
> >> + * Return a short name for a notes ref, suitable for display to the user.
> >> + *
> >> + * No copy is done, the return value is a pointer into the original string.
> >> + */
> >> +const char *notes_ref_shortname(const char *ref);
> >> +
> >> +/*
> >
> > Please include in the documentation what a NULL return means.
> >
> > Otherwise the patch looks OK.
> 
> It may be just me, but every time somebody says Factorize, I find myself
> looking for math textbook from middle school days, 12 = 2 * 2 * 3, etc.
> 
> Could we say Refactor instead pretty please?

Well, factorizing is just one kind of code refactoring - but OK, I'll
do that ;)