public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Heiko Voigt <hvoigt@hvoigt•net>
To: Nguyen Thai Ngoc Duy <pclouds@gmail•com>
Cc: Fredrik Gustafsson <iveqy@iveqy•com>,
	git@vger•kernel.org, jens.lehmann@web•de, gitster@pobox•com
Subject: Re: [PATCH v3 1/2] rev-parse: add option --is-well-formed-git-dir [path]
Date: Sat, 13 Aug 2011 08:13:43 +0200	[thread overview]
Message-ID: <20110813061342.GA459@book.hvoigt.net> (raw)
In-Reply-To: <CACsJy8D7W54w3ji6foXySCuvNLLBu=FY70z8+kB5hmJT_-3yCg@mail.gmail.com>

Hi,

On Sat, Aug 13, 2011 at 09:49:56AM +0700, Nguyen Thai Ngoc Duy wrote:
> On Sat, Aug 13, 2011 at 2:55 AM, Fredrik Gustafsson <iveqy@iveqy•com> wrote:
> \> +--is-well-formed-git-dir [path]::
> > + ?? ?? ?? Check if [path] is a valid git-dir or a git-file pointing to a valid
> > + ?? ?? ?? git-dir. If [path] is a valid git-dir the resolved path to git-dir will
> > + ?? ?? ?? be printed.
> 
> May I suggest --is-valid-git-dir?

While we are talking about names how about:

	--resolve-git-dir

? Since we had this information already the option prints out the found
resolved git directory and could be used for that.

Cheers Heiko

  reply	other threads:[~2011-08-13  6:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 19:55 [PATCH v3 0/2] submodule: move gitdir into superproject Fredrik Gustafsson
2011-08-12 19:55 ` [PATCH v3 1/2] rev-parse: add option --is-well-formed-git-dir [path] Fredrik Gustafsson
2011-08-12 20:57   ` Junio C Hamano
2011-08-13  2:49   ` Nguyen Thai Ngoc Duy
2011-08-13  6:13     ` Heiko Voigt [this message]
2011-08-14 21:42       ` Junio C Hamano
2011-08-12 19:55 ` [PATCH v3 2/2] Move git-dir for submodules Fredrik Gustafsson
2011-08-15 14:30   ` Marc Branchaud
2011-08-15 15:14     ` Fredrik Gustafsson
2011-08-16 17:34   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110813061342.GA459@book.hvoigt.net \
    --to=hvoigt@hvoigt$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=iveqy@iveqy$(echo .)com \
    --cc=jens.lehmann@web$(echo .)de \
    --cc=pclouds@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox