From: Eric Wong <normalperson@yhbt•net>
To: Piotr Krukowiecki <piotr.krukowiecki@gmail•com>
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH/RFC] git-svn: remove auto_abbrev (Getopt::Long option)
Date: Wed, 17 Aug 2011 01:02:10 +0000 [thread overview]
Message-ID: <20110817010210.GA1189@dcvr.yhbt.net> (raw)
In-Reply-To: <4E46DF9C.8040900@gmail.com>
Piotr Krukowiecki <piotr.krukowiecki@gmail•com> wrote:
> RFC because this changes user interface (no option abbreviation),
> but I know no other good way to fix the --author problem.
>
> The --author option would be useful, because I usually use
> git svn log --oneline
> and paste the changes with svn revision numbers to bugzilla etc.
>
> All tests pass with this change.
How about minimizing the impact and potential breakage with this?
(I'm not sure if "blame" benefits/hurts from this, I almost never
use any form of it)
diff --git a/git-svn.perl b/git-svn.perl
index 96f373f..ba382eb 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -298,6 +298,9 @@ my %opts = %{$cmd{$cmd}->[2]} if (defined $cmd);
read_git_config(\%opts);
if ($cmd && ($cmd eq 'log' || $cmd eq 'blame')) {
Getopt::Long::Configure('pass_through');
+ if ($cmd eq 'log') {
+ Getopt::Long::Configure('no_auto_abbrev');
+ }
}
my $rv = GetOptions(%opts, 'help|H|h' => \$_help, 'version|V' => \$_version,
'minimize-connections' => \$Git::SVN::Migration::_minimize,
--
Eric Wong
prev parent reply other threads:[~2011-08-17 1:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-13 20:33 [PATCH/RFC] git-svn: remove auto_abbrev (Getopt::Long option) Piotr Krukowiecki
2011-08-17 1:02 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817010210.GA1189@dcvr.yhbt.net \
--to=normalperson@yhbt$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=piotr.krukowiecki@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox