From: Heiko Voigt <hvoigt@hvoigt•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: Fredrik Gustafsson <iveqy@iveqy•com>,
git@vger•kernel.org, jens.lehmann@web•de
Subject: Re: [PATCH v4 2/2] push: Don't push a repository with unpushed submodules
Date: Fri, 19 Aug 2011 22:44:33 +0200 [thread overview]
Message-ID: <20110819204433.GD27639@book.hvoigt.net> (raw)
In-Reply-To: <7v4o1ea2at.fsf@alter.siamese.dyndns.org>
Hi,
On Thu, Aug 18, 2011 at 01:32:26PM -0700, Junio C Hamano wrote:
> Heiko Voigt <hvoigt@hvoigt•net> writes:
> > Since I do not see thisi in pu maybe you missed this? There was a series
> > containing the same patch send before which Jens asked to ignore but
> > this was the one which was meant to be included.
>
> Hmm, this is how the messages look like in my threaded MUA:
>
> [ 34: Fredrik Gustafsson ] [PATCH v4 0/2] push limitations
> [ 377: Fredrik Gustafsson ] [PATCH v4 2/2] push: Don't push a reposi...
> [ 35: Jens Lehmann ] Re: [PATCH v4 0/2] push limitations
> [ 377: Fredrik Gustafsson ] [PATCH v4 2/2] push: Don't push a reposit...
> [ 14: Heiko Voigt ]
>
> where Jens says "Please ignore this series, it slipped by accident" in the
> third one. And the second [PATCH v4 2/2] message that you are reminding me
> of (thanks!) has the identical proposed commit log message and patch text
> as the other [PATCH v4 2/2] message.
>
> So I am not sure what is going on here.
Sorry for confusing you.
There was a patch series which included a patch which was the same as
the patch I replied to. This was sent by accident since it also included
an old patch which was originally part of the 'fg/submodule-git-file-git-dir'
series.
Afterwards Fredrik also sent the same patch on its own again but forgot
to edit the subject. That was the patch to be included. But we already
discovered a small bug in the option parsing and will probably add
another patch implementing the on-demand option. So its probably simpler
if you just wait for our next iteration.
> Also I vaguely recall that I said something about the command line parser
> for this new option during the review of the previous round. Has that been
> resolved/corrected?
We plan to make the --recurse-submodules option symmetric to the one
already implemented in fetch. AFAIK, having a mixed boolean and other
values option is only possible by using a callback. To make extending it
simpler we decided to put the necessary infrastructure already in place.
Cheers Heiko
next prev parent reply other threads:[~2011-08-19 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 9:03 [PATCH v4 2/2] push: Don't push a repository with unpushed submodules Fredrik Gustafsson
2011-08-18 19:21 ` Heiko Voigt
2011-08-18 20:32 ` Junio C Hamano
2011-08-19 20:44 ` Heiko Voigt [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-14 8:57 [PATCH v4 0/2] push limitations Fredrik Gustafsson
2011-08-14 8:57 ` [PATCH v4 2/2] push: Don't push a repository with unpushed submodules Fredrik Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110819204433.GD27639@book.hvoigt.net \
--to=hvoigt@hvoigt$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=iveqy@iveqy$(echo .)com \
--cc=jens.lehmann@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox