Subject: Re: gitweb: 404 links on some blob pages

From: Jakub Narebski <[email-masked]>
Date: Mon, 28 Nov 2011 18:24:53 +0100

Jürgen Kreileder wrote:
> 2011/11/27 Jakub Narebski <[email-masked]>:
> > Jürgen Kreileder <[email-masked]> writes:
> >
> > > some blob pages have broken links:
> > >
> > > For example, on
> > > https://git.blackdown.de/?p=contactalbum.git;a=blob;f=Classes/WindowController.m;h=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a
> > > the blob_plain link for WindowController.m leads to '404 - Cannot find file':
> > > https://git.blackdown.de/?p=contactalbum.git;a=blob_plain;f=Classes/WindowController.m;hb=b84d1882cb6c3a2d2058cbdd56b2280b48f1690a
> >
> > That is strange.  The check is the same for 'blob' and 'blob_plain'
> > action...
> 
> The problem is the missing hash (h) parameter for the latter URL.
> Adding it to the blob_plain link makes it work.  Just as removing it
> from the blob link breaks that one as well.

Strange.  From the look of the page it looks like the 'hb' ("hash_base")
parameter that should lead to the commit from which we get the file is
bogus.

But the "raw" link uses 

  href(action=>"blob_plain", -replay=>1)

which means that if 'blob' has "h" set correctly, then 'blob_plain'
should too.

> Adding h=... to the tree link doesn't fix that case, though.

Of course it doesn't if you just copy _blob_ hash as _tree_ hash... :-P
(i.e. if you just copy "h" parameter from 'blob' URL).

-- 
Jakub Narebski
Poland