public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Eric Wong <normalperson@yhbt•net>
To: Steven Walter <stevenrwalter@gmail•com>
Cc: gitster@pobox•com, git@vger•kernel.org
Subject: Re: [PATCH] git-svn.perl: fix a false-positive in the "already exists" test
Date: Wed, 22 Feb 2012 00:33:17 +0000	[thread overview]
Message-ID: <20120222003317.GA1069@dcvr.yhbt.net> (raw)
In-Reply-To: <1329747474-17976-1-git-send-email-stevenrwalter@gmail.com>

Steven Walter <stevenrwalter@gmail•com> wrote:
> open_or_add_dir checks to see if the directory already exists or not.
> If it already exists and is not a directory, then we fail.  However,
> open_or_add_dir did not previously account for the possibility that the
> path did exist as a file, but is deleted in the current commit.
> 
> In order to prevent this legitimate case from failing, open_or_add_dir
> needs to know what files are deleted in the current commit.
> Unfortunately that information has to be plumbed through a couple of
> layers.
> 
> Signed-off-by: Steven Walter <stevenrwalter@gmail•com>

Thanks, will push.
Acked-by: Eric Wong <normalperson@yhbt•net>

next prev parent reply	other threads:[~2012-02-22  0:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 18:55 [PATCH 1/2] git-svn.perl: perform deletions before anything else Steven Walter
2012-02-09 18:55 ` [PATCH 2/2] git-svn.perl: fix a false-positive in the "already exists" test Steven Walter
2012-02-09 20:08 ` [PATCH 1/2] git-svn.perl: perform deletions before anything else Junio C Hamano
2012-02-09 20:52   ` Steven Walter
2012-02-09 20:52     ` Steven Walter
2012-02-12  7:03       ` Eric Wong
2012-02-12 15:35         ` Steven Walter
2012-02-12 23:49           ` Eric Wong
2012-02-15 17:47             ` Steven Walter
2012-02-19 10:54               ` Eric Wong
2012-02-20 14:17                 ` [PATCH] git-svn.perl: fix a false-positive in the "already exists" test Steven Walter
2012-02-22  0:33                   ` Eric Wong [this message]
2012-02-22  2:16                   ` Junio C Hamano
2012-02-22  2:32                     ` Steven Walter
2012-02-22  5:08                       ` Junio C Hamano
2012-02-23 23:17                         ` Steven Walter
     [not found] ` <87mx8rrf5i.fsf@thomas.inf.ethz.ch>
     [not found]   ` <CAK8d-aJ3wi0e_NPunow-aBnhs1=o5K25r3e-Ha0m1U0ujTv7OA@mail.gmail.com>
2012-02-09 20:55     ` [PATCH 1/2] git-svn.perl: perform deletions before anything else Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120222003317.GA1069@dcvr.yhbt.net \
    --to=normalperson@yhbt$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=stevenrwalter@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox