Subject: Re: [PATCH 6/7] unpack-trees: record which unpack error messages should be freed

From: Jonathan Nieder <[email-masked]>
Date: Mon, 21 May 2012 15:43:50 -0500

Christian Couder wrote:

> "struct unpack_trees_options" has a "const char *msgs[]" field
> that is setup with string values in setup_unpack_trees_porcelain().

Hmm.  Incidentally, should callers (e.g., the 100 single-picks
involved in a large multi-pick) be reusing these strings instead of
allocating them again and again?