From: Eric Wong <normalperson@yhbt•net>
To: "Michael G. Schwern" <schwern@pobox•com>
Cc: git@vger•kernel.org, gitster@pobox•com, robbat2@gentoo•org,
bwalton@artsci•utoronto.ca, Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCH 1/4] Extract some utilities from git-svn to allow extracting Git::SVN.
Date: Wed, 25 Jul 2012 21:24:18 +0000 [thread overview]
Message-ID: <20120725212418.GA17494@dcvr.yhbt.net> (raw)
In-Reply-To: <1343196066-81319-2-git-send-email-schwern@pobox.com>
"Michael G. Schwern" <schwern@pobox•com> wrote:
> From: "Michael G. Schwern" <schwern@pobox•com>
>
> Put them in a new module called Git::SVN::Utils. Yeah, not terribly
> original and it will be a dumping ground. But its better than having
> them in the main git-svn program. At least they can be documented
> and tested.
>
> * fatal() is used by many classes.
> * Change the $can_compress lexical into a function.
>
> This should be enough to extract Git::SVN.
Please keep Jonathan Cc:-ed, he's been very helpful with this series
(and very helpful in general :)
This series is mostly alright by me, a few minor comments inline.
> --- /dev/null
> +++ b/t/Git-SVN/00compile.t
> +
> +use Test::More tests => 1;
> +++ b/t/Git-SVN/Utils/fatal.t
> @@ -0,0 +1,34 @@
> +
> +use Test::More 'no_plan';
Didn't we agree to use done_testing()? Perhaps (as you suggested) with
a private copy of Test::More? It's probably easier to start using
done_testing() earlier rather than later.
> +BEGIN {
> + # Override exit at BEGIN time before Git::SVN::Utils is loaded
> + # so it will see our local exit later.
> + *CORE::GLOBAL::exit = sub(;$) {
> + return @_ ? CORE::exit($_[0]) : CORE::exit();
> + };
> +}
For new code related to git-svn, please match the existing indentation
style (tabs) prevalent in git-svn. Most of the Perl found in git also
uses tabs for indentation.
next prev parent reply other threads:[~2012-07-25 21:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 6:01 Move Git::SVN into its own .pm file Michael G. Schwern
2012-07-25 6:01 ` [PATCH 1/4] Extract some utilities from git-svn to allow extracting Git::SVN Michael G. Schwern
2012-07-25 21:24 ` Eric Wong [this message]
2012-07-25 22:39 ` Michael G Schwern
2012-07-25 23:08 ` Eric Wong
2012-07-26 0:01 ` Michael G Schwern
2012-07-26 0:25 ` Eric Wong
2012-07-26 0:26 ` Jonathan Nieder
2012-07-25 6:01 ` [PATCH 2/4] Prepare Git::SVN for extraction into its own file Michael G. Schwern
2012-07-25 6:01 ` [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN Michael G. Schwern
2012-07-25 21:15 ` Move Git::SVN into its own .pm file Jonathan Nieder
2012-07-25 21:56 ` Michael G Schwern
-- strict thread matches above, loose matches on Subject: below --
2012-07-26 23:22 Extract Git::SVN from git-svn, take 2 Michael G. Schwern
2012-07-26 23:22 ` [PATCH 1/4] Extract some utilities from git-svn to allow extracting Git::SVN Michael G. Schwern
2012-07-27 5:18 ` Junio C Hamano
2012-07-27 8:19 ` Michael G Schwern
2012-07-27 11:34 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120725212418.GA17494@dcvr.yhbt.net \
--to=normalperson@yhbt$(echo .)net \
--cc=bwalton@artsci$(echo .)utoronto.ca \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=robbat2@gentoo$(echo .)org \
--cc=schwern@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox