From: Eric Wong <normalperson@yhbt•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: Jonathan Nieder <jrnieder@gmail•com>,
"Michael G. Schwern" <schwern@pobox•com>,
git@vger•kernel.org, robbat2@gentoo•org,
bwalton@artsci•utoronto.ca
Subject: Re: [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN.
Date: Fri, 27 Jul 2012 15:45:54 -0700 [thread overview]
Message-ID: <20120727224554.GA30385@dcvr.yhbt.net> (raw)
In-Reply-To: <7vboj0zv7t.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox•com> wrote:
> Eric Wong <normalperson@yhbt•net> writes:
> > The redundant dependencies are biting us :< I agree there presence in
> > the top-level Makefile needs to be reviewed.
>
> Do you feel confident enough that we can leave that question hanging
> around and still merge this before 1.7.12 safely?
Yes.
> I do not think it is a regression at the Makefile level per-se---we
> didn't have right dependencies to keep perl.mak up to date, which
> was the root cause of what we observed.
>
> But the lack of dependencies did not matter before this series
> because the list of *.pm files never changed, so in that sense the
> series is what introduced the build regression, and I do not have a
> solid feeling that we squashed it.
Right, I agree the original dependencies are not good and it's not
a recent regression in the Makefile level.
I do feel our patch deals with the problem for now. I've been going
between commits in Michael's 3rd series and haven't noticed new issues
when running the tests.
next prev parent reply other threads:[~2012-07-27 22:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 23:22 Extract Git::SVN from git-svn, take 2 Michael G. Schwern
2012-07-26 23:22 ` [PATCH 1/4] Extract some utilities from git-svn to allow extracting Git::SVN Michael G. Schwern
2012-07-27 5:18 ` Junio C Hamano
2012-07-27 8:19 ` Michael G Schwern
2012-07-27 11:34 ` Eric Wong
2012-07-26 23:22 ` [PATCH 2/4] Prepare Git::SVN for extraction into its own file Michael G. Schwern
2012-07-27 5:18 ` Junio C Hamano
2012-07-27 5:23 ` Junio C Hamano
2012-07-27 8:16 ` Michael G Schwern
2012-07-27 11:53 ` Eric Wong
2012-07-26 23:22 ` [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN Michael G. Schwern
2012-07-27 5:18 ` Junio C Hamano
2012-07-27 5:38 ` Jonathan Nieder
2012-07-27 6:07 ` Junio C Hamano
2012-07-27 6:46 ` Junio C Hamano
2012-07-27 7:09 ` Junio C Hamano
2012-07-27 20:07 ` Eric Wong
2012-07-27 20:56 ` Michael G Schwern
2012-07-27 20:59 ` Eric Wong
2012-07-27 21:31 ` Junio C Hamano
2012-07-27 21:49 ` Junio C Hamano
2012-07-27 22:07 ` Eric Wong
2012-07-27 22:19 ` Eric Wong
2012-07-27 22:37 ` Junio C Hamano
2012-07-27 22:45 ` Eric Wong [this message]
2012-07-27 22:59 ` Junio C Hamano
2012-07-27 23:01 ` Eric Wong
2012-07-27 22:52 ` Junio C Hamano
2012-07-27 11:59 ` Eric Wong
2012-07-27 8:41 ` Michael G Schwern
-- strict thread matches above, loose matches on Subject: below --
2012-07-25 6:01 Move Git::SVN into its own .pm file Michael G. Schwern
2012-07-25 6:01 ` [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN Michael G. Schwern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120727224554.GA30385@dcvr.yhbt.net \
--to=normalperson@yhbt$(echo .)net \
--cc=bwalton@artsci$(echo .)utoronto.ca \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=robbat2@gentoo$(echo .)org \
--cc=schwern@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox