Subject: Re: [PATCH] Add getenv.so for catching invalid getenv() use via LD_PRELOAD

From: Matt Kraai <[email-masked]>
Date: Sat, 5 Jan 2013 02:39:00 -0800

On Sat, Jan 05, 2013 at 03:55:46PM +0700, Nguyễn Thái Ngọc Duy wrote:
>  Perhaps this will help the getenv bug hunting (I assume we do the
>  hunting on Linux platform only). So far it catches this and is stuck
>  at getenv in git_pager().

It seems like a static analysis tool might be able to detect these
problems.  Is there a way to do so using sparse?

> +		n = backtrace(buffer, 100);
> +		symbols = backtrace_symbols(buffer, n);
> +		if (symbols) {
> +			for (i = 0;i < n; i++)

s/;i/; i/

-- 
Matt Kraai
https://ftbfs.org/kraai