Subject: Re: [PATCH 1/8] cherry-pick, revert: add the --gpg-sign option

From: Nicolas Vigier <[email-masked]>
Date: Sun, 3 Nov 2013 19:00:59 +0100

On Sun, 03 Nov 2013, brian m. carlson wrote:

> On Sun, Nov 03, 2013 at 04:54:17PM +0100, Nicolas Vigier wrote:
> > diff --git a/sequencer.h b/sequencer.h
> > index 1fc22dcabe13..db43e9cf86dc 100644
> > --- a/sequencer.h
> > +++ b/sequencer.h
> > @@ -37,6 +37,8 @@ struct replay_opts {
> >  
> >  	int mainline;
> >  
> > +	const char *gpg_sign;
> > +
> >  	/* Merge strategy */
> >  	const char *strategy;
> >  	const char **xopts;
> 
> One thing you're missing here is the ability to save and retrieve the
> options.  You might be cherry-picking or reverting multiple commits and
> get interrupted (maybe one is already applied) and need to use
> --continue.
> 
> So populate_options_cb and save_opts need to learn about this sequencer
> option so that after --continue, commits continue to get signed.

Ah indeed, I didn't think about that. I will look at it. Thanks.