Subject: Re: [PATCH] parse-options: remove OPT_BOOLEAN

From: Jonathan Nieder <[email-masked]>
Date: Sun, 8 Dec 2013 14:23:52 -0800

Hi,

Nguyễn Thái Ngọc Duy wrote:

> After a86a8b9 (sb/parseopt-boolean-removal), the deprecated
> OPT_BOOLEAN is not used anywhere except by OPT__* macros.

Yeah, I noticed the same thing too recently.

[...]
>                                              All OPT__DRY_RUN call
> sites have been checked and they look safe for OPT_BOOL.

This is the only functional change from the patch.  A repeated
--dry-run that behaves differently from --dry-run would be very weird,
and a quick check of OPT__DRY_RUN uses in pu confirms that with
current callers the patch is a no-op (except in the weird case that
someone overflows an "int" with a very long -nnnnnnn...  commandline).

Reviewed-by: Jonathan Nieder <[email-masked]>

Thanks.