From: John Keeping <john@keeping•me.uk>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org, Daniel Hahler <genml+git-2014@thequod•de>
Subject: Re: [PATCH] rev-parse: fix --resolve-git-dir argument handling
Date: Wed, 19 Feb 2014 09:09:48 +0000 [thread overview]
Message-ID: <20140219090948.GD1048@serenity.lan> (raw)
In-Reply-To: <xmqqzjlo9ce6.fsf@gitster.dls.corp.google.com>
On Tue, Feb 18, 2014 at 04:25:37PM -0800, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox•com> writes:
>
> > John Keeping <john@keeping•me.uk> writes:
> >
> >> There are two problems here:
> >>
> >> 1) If no argument is provided, then the command segfaults
> >> 2) The argument is not consumed, so there will be excess output
> >>
> >> Fix both of these in one go by restructuring the handler for this
> >> option.
> >>
> >> Reported-by: Daniel Hahler <genml+git-2014@thequod•de>
> >> Signed-off-by: John Keeping <john@keeping•me.uk>
> >> ---
> >
> > Looks sensible; thanks.
>
> Ehh, I spoke too fast. Don't we already have this queued as a43219f2
> (rev-parse: check i before using argv[i] against argc, 2014-01-28)?
Yes, and it catches more cases than mine. I only checked against master
and had missed that when it went past on the list.
prev parent reply other threads:[~2014-02-19 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 8:13 Output from "rev-parse --resolve-git-dir" changed: two lines (prints original argument) Daniel Hahler
2014-02-17 8:46 ` [PATCH] rev-parse: fix --resolve-git-dir argument handling John Keeping
2014-02-18 20:42 ` Junio C Hamano
2014-02-19 0:25 ` Junio C Hamano
2014-02-19 9:09 ` John Keeping [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219090948.GD1048@serenity.lan \
--to=john@keeping$(echo .)me.uk \
--cc=genml+git-2014@thequod$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox