public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jonathan Nieder <jrnieder@gmail•com>
To: Uwe Storbeck <uwe@ibr•ch>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: Corner case bug caused by shell dependent behavior
Date: Thu, 13 Mar 2014 17:37:01 -0700	[thread overview]
Message-ID: <20140314003701.GF15625@google.com> (raw)
In-Reply-To: <20140314000213.GA3739@ibr.ch>

Hi,

Uwe Storbeck wrote:

> To reproduce the behavior (with dash as /bin/sh):
>
>   mkdir test && cd test && git init
>   echo 1 >foo && git add foo
>   git commit -m"this commit message ends with '\n'"
>   echo 2 >foo && git commit -a --fixup HEAD
>   git rebase -i --autosquash --root
>
> Now the editor opens with garbage in line 3 which has to be
> removed or the rebase fails.

Would it make sense to add this as a test to e.g.
t/t3404-rebase-interactive.sh?

> The attached one-line patch fixes the bug.

May we have your sign-off?  (See Documentation/SubmittingPatches
section "Sign your work" for what this means.

Looks obviously correct, so for what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail•com>

Thanks,
Jonathan

next prev parent reply	other threads:[~2014-03-14  0:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14  0:02 Corner case bug caused by shell dependent behavior Uwe Storbeck
2014-03-14  0:37 ` Jonathan Nieder [this message]
2014-03-14 23:53   ` Uwe Storbeck
2014-03-14  2:28 ` Jeff King
2014-03-14  6:08   ` David Kastrup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140314003701.GF15625@google.com \
    --to=jrnieder@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=uwe@ibr$(echo .)ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox