Subject: Re: [PATCH v3 06/19] refs.c: make update_ref_write to return error string on failure

From: Jonathan Nieder <[email-masked]>
Date: Fri, 25 Apr 2014 15:45:07 -0700

Ronnie Sahlberg wrote:

> Change update_ref_write to also return an error string on failure.
> This makes the error avaialbel to ref_transaction_commit callers if the
> transaction failed dur to update_ref_sha1/write_ref_sha1 failures.

Nits:

 * available
 * during

Probably should come right after or before patch 3.  Same nit as patch
3 about using asprintf or passing in a pointer to strbuf.