Subject: Re: [PATCH 2/2] blame: simplify prepare_lines()

From: Jonathan Nieder <[email-masked]>
Date: Fri, 13 Jun 2014 14:13:39 -0700

René Scharfe wrote:

> -	if (incomplete)
> -		*lineno++ = len;
> +	*lineno = len;
>  
> -	sb->num_lines = num + incomplete;
> +	sb->num_lines = num;

This will always treat whatever comes after the last newline as an
incomplete line, even if it has zero length.  Is that safe?  (Not a
rhetorical question --- I haven't looked carefully at the caller.)

Thanks,
Jonathan