From: Jeff King <peff@peff•net>
To: Alexander Shopov <ash@kambanaria•org>
Cc: git@vger•kernel.org, avarab@gmail•com, jn.avila@free•fr,
worldhello.net@gmail•com, marcopaolone@gmail•com,
marcomsousa@gmail•com, peter@softwolves•pp.se,
ralf.thielow@gmail•com, gitster@pobox•com
Subject: Re: [PATCH] Fixing unclear messages
Date: Sun, 10 Aug 2014 15:37:00 -0400 [thread overview]
Message-ID: <20140810193659.GB9886@peff.net> (raw)
In-Reply-To: <1407683607-4143-2-git-send-email-ash@kambanaria.org>
On Sun, Aug 10, 2014 at 06:13:27PM +0300, Alexander Shopov wrote:
> Signed-off-by: Alexander Shopov <ash@kambanaria•org>
It would probably make sense to put the discussion from your cover
letter into the commit message.
> diff --git a/builtin/index-pack.c b/builtin/index-pack.c
> index 5568a5b..d9c5911 100644
> --- a/builtin/index-pack.c
> +++ b/builtin/index-pack.c
> @@ -1064,7 +1064,7 @@ static void parse_pack_objects(unsigned char *sha1)
> nr_delays--;
> }
> if (nr_delays)
> - die(_("confusion beyond insanity in parse_pack_objects()"));
> + die(_("fatal error in function \"parse_pack_objects\". This is a bug in Git. Please report it to the developers with an e-mail to git@vger•kernel.org."));
> }
We usually just say:
die("BUG: ...");
here (and hopefully the "..." actually describes the situation a bit
better). I have wondered if we should actually introduce a
BUG("...");
function. Then it would make it simple to be more verbose (e.g.,
pointing the user to the mailing list as you do here) without having to
repeat the text in each place.
-Peff
next prev parent reply other threads:[~2014-08-10 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-10 15:13 [PATCH] Fixning WTF porcelain messages Alexander Shopov
2014-08-10 15:13 ` [PATCH] Fixing unclear messages Alexander Shopov
2014-08-10 19:37 ` Jeff King [this message]
2014-08-11 0:00 ` Junio C Hamano
2014-08-11 9:13 ` Alexander Shopov
2014-08-11 18:21 ` Junio C Hamano
2014-08-11 20:04 ` Alexander Shopov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140810193659.GB9886@peff.net \
--to=peff@peff$(echo .)net \
--cc=ash@kambanaria$(echo .)org \
--cc=avarab@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jn.avila@free$(echo .)fr \
--cc=marcomsousa@gmail$(echo .)com \
--cc=marcopaolone@gmail$(echo .)com \
--cc=peter@softwolves$(echo .)pp.se \
--cc=ralf.thielow@gmail$(echo .)com \
--cc=worldhello.net@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox