Subject: Re: [PATCH v5 12/35] prepare_index(): declare return value to be (const char *)

From: Jonathan Nieder <[email-masked]>
Date: Tue, 16 Sep 2014 14:17:09 -0700

Michael Haggerty wrote:

> Declare the return value to be const to make it clear that we aren't
> giving callers permission to write over the string that it points at.
> (The return value is the filename field of a struct lock_file, which
> can be used by a signal handler at any time and therefore shouldn't be
> tampered with.)
>
> Signed-off-by: Michael Haggerty <[email-masked]>
> ---
>  builtin/commit.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Jonathan Nieder <[email-masked]>

I wonder if we should just bite the bullet and make lock_file an
opaque struct with accessors for int fd and const char *filename.