From: Jeff King <peff@peff•net>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>,
Michael Haggerty <mhagger@alum•mit.edu>
Subject: Re: [PATCH 2/3] t5304: use helper to report failure of "test foo = bar"
Date: Mon, 13 Oct 2014 17:15:25 -0400 [thread overview]
Message-ID: <20141013211524.GB15969@peff.net> (raw)
In-Reply-To: <20141013161022.GA20520@google.com>
On Mon, Oct 13, 2014 at 09:10:22AM -0700, Jonathan Nieder wrote:
> Jeff King wrote:
>
> > For small outputs, we sometimes use:
> >
> > test "$(some_cmd)" = "something we expect"
> >
> > instead of a full test_cmp. The downside of this is that
> > when it fails, there is no output at all from the script.
>
> There's another downside to that construct: it loses the exit
> status from some_cmd.
Yes, although I think in many cases it's not a big deal. For example,
here we lose the exit code of count-objects, but it also is very
unlikely to fail _and_ produce our expected output.
> Alternatively, maybe there could be a helper in the same spirit as
> test_cmp_rev?
>
> test_object_count () {
> git count-objects >output &&
> sed "s/ .*//" output >count &&
> printf "%s\n" "$1" >expect &&
> test_cmp expect count
> }
One of my goals was to provide a more generic helper so that we don't
have to make little helpers like this for every command. So I'd much
rather something like:
test_output () {
printf "%s\n" "$1" >expect &&
shift &&
"$@" >output &&
test_cmp expect output
}
The "\n" handling there feels a little hacky, but is probably OK in
practice (the few commands that really do generate an output without a
newline can use test_cmp manually). It should probably also "rm" the
files on success to avoid polluting the working tree.
It also doesn't help cases that want to do "test $foo -lt 3" or other
non-equality checks. But those are probably the minority.
I dunno. I am OK with what I posted, but if we feel strongly about
testing the exit code, I can re-roll as test_output as above.
-Peff
next prev parent reply other threads:[~2014-10-13 21:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 6:06 [PATCH 0/3] "-x" tracing option for tests Jeff King
2014-10-10 6:07 ` [PATCH 1/3] t5304: use test_path_is_* instead of "test -f" Jeff King
2014-10-10 6:11 ` [PATCH 2/3] t5304: use helper to report failure of "test foo = bar" Jeff King
2014-10-13 16:10 ` Jonathan Nieder
2014-10-13 21:15 ` Jeff King [this message]
2014-10-13 21:31 ` Jonathan Nieder
2014-10-13 21:33 ` Junio C Hamano
2014-10-13 21:38 ` Jonathan Nieder
2014-10-13 21:56 ` Junio C Hamano
2014-10-13 21:36 ` Jeff King
2014-10-10 6:13 ` [PATCH 3/3] test-lib.sh: support -x option for shell-tracing Jeff King
2014-10-10 6:21 ` Jeff King
2014-10-10 6:47 ` [PATCH v2 " Jeff King
2014-10-13 18:43 ` Junio C Hamano
2014-10-13 22:22 ` Junio C Hamano
2014-10-13 22:31 ` Junio C Hamano
2014-10-13 22:33 ` Jeff King
2014-10-13 22:38 ` Junio C Hamano
2014-10-13 22:43 ` Jeff King
2014-10-13 23:14 ` Junio C Hamano
2014-10-14 0:46 ` Jeff King
2014-10-10 6:27 ` [PATCH " Jeff King
2014-10-13 18:24 ` [PATCH 0/3] "-x" tracing option for tests Junio C Hamano
2014-10-13 21:07 ` Jeff King
2014-10-14 8:52 ` Michael Haggerty
2014-10-14 13:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013211524.GB15969@peff.net \
--to=peff@peff$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=mhagger@alum$(echo .)mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox