From: Jeff King <peff@peff•net>
To: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
Cc: Junio C Hamano <gitster@pobox•com>,
GIT Mailing-list <git@vger•kernel.org>
Subject: Re: [PATCH] revision: remove definition of unused 'add_object' function
Date: Sat, 18 Oct 2014 21:36:46 -0400 [thread overview]
Message-ID: <20141019013646.GA17908@peff.net> (raw)
In-Reply-To: <5442DD4C.9050908@ramsay1.demon.co.uk>
On Sat, Oct 18, 2014 at 10:36:12PM +0100, Ramsay Jones wrote:
> I noticed that your 'jk/prune-mtime' branch removes the last caller
> of the add_object() function; specifically commit 5f78a431a
> ("reachable: use traverse_commit_list instead of custom walk", 15-10-2014).
Thanks. I usually rely on the compiler to catch any static instances
that I missed, but of course this one is extern. Did you use an
automated tool for this (I know you often catch "X has no declaration;
should it be static?" with clang, but does clang catch this, too?).
> If you need to re-roll those patches, could you please squash this
> patch into the above commit. (unless you have plans to add some new
> callers, of course! ;-) ).
Nope, I just didn't notice that I dropped the last caller. I don't think
we need another re-roll (fingers crossed), but I'd be happy to have this
on top.
-Peff
next prev parent reply other threads:[~2014-10-19 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-18 21:36 [PATCH] revision: remove definition of unused 'add_object' function Ramsay Jones
2014-10-19 1:36 ` Jeff King [this message]
2014-10-19 10:16 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019013646.GA17908@peff.net \
--to=peff@peff$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=ramsay@ramsay1$(echo .)demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox