Subject: Re: [PATCH] use child_process_init() to initialize struct child_process variables

From: Jeff King <[email-masked]>
Date: Mon, 10 Nov 2014 02:14:10 -0500

On Sun, Nov 09, 2014 at 02:49:58PM +0100, René Scharfe wrote:

> -- >8 --
> Subject: [PATCH] trailer: use CHILD_PROCESS_INIT in apply_command()
> 
> Initialize the struct child_process variable cp at declaration time.
> This is shorter, saves a function call and prevents using the variable
> before initialization by mistake.
> 
> Suggested-by: Jeff King <[email-masked]>
> Signed-off-by: Rene Scharfe <[email-masked]>
> ---
>  trailer.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, both this one and the other you just sent (to use
child_process.args in more places) look good to me.

-Peff