Subject: Re: [PATCH] t960[34]: mark cvsimport tests as requiring perl

From: Jonathan Nieder <[email-masked]>
Date: Tue, 18 Nov 2014 10:56:22 -0800

Jeff King wrote:

> It would probably make sense to have these scripts just
> skip_all if NO_PERL is set, but I opted to follow the pattern
> set by t9600, etc. If somebody feels like spending time refactoring the
> cvsimport test harness, be my guest.

Wouldn't it be a matter of the following, plus (optionally) dropping
the existing PERL prerequisites on cvs tests?

-- >8 --
Subject: test: cvsimport requires perl

Git-cvsimport is written in perl, which understandably causes the
tests to fail if you build with NO_PERL (which will avoid building
cvsimport at all). The earlier cvsimport tests in t9600-t9602 are all
marked with a PERL prerequisite, but t9603 and 9604 are not.

The one in t9603 was likely not noticed because it is an expected
failure.

The ones in t9604 have been around for a long time, but it is likely
that the combination of NO_PERL and having cvsps installed is rare
enough that nobody noticed.

Reported-by: Jeff King <[email-masked]>
Signed-off-by: Jonathan Nieder <[email-masked]>
---
 t/lib-cvs.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/t/lib-cvs.sh b/t/lib-cvs.sh
index 9b2bcfb..b75df11 100644
--- a/t/lib-cvs.sh
+++ b/t/lib-cvs.sh
@@ -10,6 +10,12 @@ then
 	test_done
 fi
 
+if ! test_have_prereq PERL
+then
+	skip_all='skipping cvsimport tests, perl not available'
+	test_done
+fi
+
 CVS="cvs -f"
 export CVS
 
-- 
2.1.0.rc2.206.gedb03e5