Subject: Re: [PATCH 4/4] lock_ref_sha1_basic: do not die on locking errors

From: Jonathan Nieder <[email-masked]>
Date: Tue, 18 Nov 2014 18:05:03 -0800

Jeff King wrote:

> From: Ronnie Sahlberg <[email-masked]>
>
> lock_ref_sha1_basic is inconsistent about when it calls
> die() and when it returns NULL to signal an error. This is
> annoying to any callers that want to recover from a locking
> error.

And in addition to the modern transaction stuff, rename_ref() has been
such a caller for a long time.

Thanks for a pleasant explanation.

Reviewed-by: Jonathan Nieder <[email-masked]>

[...]
> Signed-off-by: Ronnie Sahlberg <[email-masked]>
> Signed-off-by: Jonathan Nieder <[email-masked]>

No need for my sign-off here --- it was just an artifact of my
forwarding the patch to the list before.