Subject: Re: [PATCH 4/4] reflog.c: use a reflog transaction when writing during expire

From: Jonathan Nieder <[email-masked]>
Date: Tue, 2 Dec 2014 19:18:26 -0800

Stefan Beller wrote:

> --- a/builtin/reflog.c
> +++ b/builtin/reflog.c
[...]
> @@ -290,7 +291,7 @@ static int unreachable(struct expire_reflog_cb *cb, struct commit *commit, unsig
>  
>  static int expire_reflog_ent(unsigned char *osha1, unsigned char *nsha1,
>  		const char *email, unsigned long timestamp, int tz,
> -		const char *message, void *cb_data)
> +		const char *message, void *cb_data, struct strbuf *err)

This doesn't match the signature of each_reflog_ent_fn.  Would putting
err in the cb_data struct work?

Curious,
Jonathan