Subject: Re: [PATCH 4/4] strbuf.h: reorganize api function grouping headers

From: Jonathan Nieder <[email-masked]>
Date: Fri, 12 Dec 2014 14:46:08 -0800

Jeff King wrote:

> If you look at the original header file, these groupings actually did
> exist (though we did not remotely follow them as functions were added),
> and looked like:
>
>   /* ---- content related ---- */
>
> I'd be happy with something like that, too, but went with the style that
> matched the "Data Structures" header.

I'd be happy either way too.

>  strbuf.h | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)

This is missing the "Adding data to the buffer" section.

Except for that,
Reviewed-by: Jonathan Nieder <[email-masked]>