From: Jeff King <peff@peff•net>
To: Beat Bolli <bbolli@ewanet•ch>
Cc: dev+git@drbeat•li, git@vger•kernel.org, tboegi@web•de
Subject: Re: [PATCH 4/5] update_unicode.sh: Make the output structure visible
Date: Fri, 19 Dec 2014 10:48:11 -0500 [thread overview]
Message-ID: <20141219154810.GB16967@peff.net> (raw)
In-Reply-To: <549447B7.8070602@ewanet.ch>
On Fri, Dec 19, 2014 at 04:43:51PM +0100, Beat Bolli wrote:
> I think the code looks much nicer with a here doc.
>
> Checking in t/, it looks that there's no consensus about whether to
> indent the content relative to the cat statement or not. What do you
> suggest?
I think we typically do it at the same level as the `cat`. Checking "git
grep -A1 '<<-'" does show a mix, but skimming over it I think what I
suggested is more common.
-Peff
next prev parent reply other threads:[~2014-12-19 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 14:39 [PATCH 1/5] update_unicode.sh: simplify output capture dev+git
2014-12-19 14:39 ` [PATCH 2/5] update_unicode.sh: set UNICODE_DIR only once dev+git
2014-12-19 14:39 ` [PATCH 3/5] update_unicode.sh: shorten uniset invocation path dev+git
2014-12-19 14:39 ` [PATCH 4/5] update_unicode.sh: Make the output structure visible dev+git
2014-12-19 15:22 ` Jeff King
2014-12-19 15:43 ` Beat Bolli
2014-12-19 15:48 ` Jeff King [this message]
2014-12-19 14:39 ` [PATCH 5/5] update_unicode.sh: Delete the command group dev+git
2014-12-19 15:12 ` [PATCH 1/5] update_unicode.sh: simplify output capture Beat Bolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219154810.GB16967@peff.net \
--to=peff@peff$(echo .)net \
--cc=bbolli@ewanet$(echo .)ch \
--cc=dev+git@drbeat$(echo .)li \
--cc=git@vger$(echo .)kernel.org \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox