From: Eric Wong <normalperson@yhbt•net>
To: Valery Yundin <yuvalery@gmail•com>
Cc: git@vger•kernel.org, Minty <mintywalker@gmail•com>,
"Nico Schlömer" <nico.schloemer@gmail•com>,
Mike <ipso@snappymail•ca>, "Junio C Hamano" <gitster@pobox•com>
Subject: Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor
Date: Fri, 30 Jan 2015 01:30:17 +0000 [thread overview]
Message-ID: <20150130013017.GA10713@dcvr.yhbt.net> (raw)
In-Reply-To: <CABNxngMVsaSLmzf0ZsaXZqXhD+hOaRmz-uuSzm0ALDFhKjnrXA@mail.gmail.com>
Valery Yundin <yuvalery@gmail•com> wrote:
> Hi,
>
> Your patch seems to fix the problem.
> I tried several times and I can svn clone the whole repository in one
> go without a crash.
Thanks for the confirmation. Cc-ing a few other folks who encountered
this problem (and Bcc-ing some folks who emailed me privately).
Can the rest of you give this patch a try on your respective platforms
and confirm the fix?
http://article.gmane.org/gmane.comp.version-control.git/263168/raw
(also: http://mid.gmane.org/20150130002247.GA22519@dcvr.yhbt.net )
Junio: assuming all goes well with testers, can you apply my patch
to the appropriate maintenance tracks with Tested-by:s?
I'm going offline in a few hours and don't think I'll be around
much the next week or so.
Thanks.
> Thanks,
> Valery
>
> On 30 January 2015 at 01:22, Eric Wong <normalperson@yhbt•net> wrote:
> > Valery Yundin <yuvalery@gmail•com> wrote:
> >> Hi,
> >>
> >> Here you go:
> >> dfa72fdb96befbd790f623bb2909a347176753c2 is the first bad commit
> >
> > Thank you. Can you give the following patch a try?
> > I have not been able to reproduce the problem on my end.
> > If it doesn't work out, I might be out of ideas for a bit :/
> > Increasing --log-window-size will help you run longer without
> > the error, but that's not ideal as it can also eat memory.
> >
> > -----------------------8<----------------------
> > From: Eric Wong <normalperson@yhbt•net>
> > Subject: [PATCH] git-svn: destroy all tempfiles when reloading RA
> >
> > This may fix the errors some users are seeing with:
> > "write .git/Git_svn_hash_XXXXXX: Bad file descriptor"
> >
> > Thanks to Valery Yundin for helping bisect the problem introduced in
> > commit dfa72fdb96befbd790f623bb2909a347176753c2
> > (git-svn: reload RA every log-window-size)
> >
> > Cc: Valery Yundin <yuvalery@gmail•com>
> > Signed-off-by: Eric Wong <normalperson@yhbt•net>
> > ---
> > perl/Git.pm | 6 ++++++
> > perl/Git/SVN/Ra.pm | 1 +
> > 2 files changed, 7 insertions(+)
> >
> > diff --git a/perl/Git.pm b/perl/Git.pm
> > index b5905ee..698018e 100644
> > --- a/perl/Git.pm
> > +++ b/perl/Git.pm
> > @@ -1347,6 +1347,12 @@ sub temp_path {
> > $TEMP_FILES{$temp_fd}{fname};
> > }
> >
> > +sub temp_reset_all {
> > + unlink values %TEMP_FILEMAP if %TEMP_FILEMAP;
> > + %TEMP_FILEMAP = ();
> > + %TEMP_FILES = ();
> > +}
> > +
> > sub END {
> > unlink values %TEMP_FILEMAP if %TEMP_FILEMAP;
> > }
> > diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
> > index 622535e..878679d 100644
> > --- a/perl/Git/SVN/Ra.pm
> > +++ b/perl/Git/SVN/Ra.pm
> > @@ -397,6 +397,7 @@ sub gs_fetch_loop_common {
> > $_[0] = undef;
> > $self = undef;
> > $RA = undef;
> > + Git->temp_reset_all;
> > $gpool->clear;
> > $self = Git::SVN::Ra->new($ra_url);
> > $ra_invalid = undef;
> > --
> > EW
> --
next prev parent reply other threads:[~2015-01-30 1:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 22:03 git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor Valery Yundin
2015-01-29 23:34 ` Eric Wong
2015-01-29 23:59 ` Valery Yundin
2015-01-30 0:22 ` Eric Wong
2015-01-30 0:40 ` Valery Yundin
2015-01-30 1:30 ` Eric Wong [this message]
2015-01-31 12:51 ` Nico Schlömer
2015-01-31 14:52 ` Valery Yundin
2015-02-12 19:18 ` Eric Wong
2015-02-16 15:10 ` Nico Schlömer
2015-02-17 6:17 ` Eric Wong
2015-02-25 10:19 ` Kyle J. McKay
[not found] ` <CAK6Z60fqEkM_tON6tcnwBqJzBCvLB=eVJdyXSnNb7N1iR_DSsw@mail.gmail.com>
2015-02-25 20:08 ` Eric Wong
2015-02-25 20:33 ` Kyle J. McKay
[not found] <CAK6Z60ciheWOUGOv1sYcA==B2WR1Rs_eMU+9a=R3FBwc_37CyQ@mail.gmail.com>
2015-02-26 9:09 ` Nico Schlömer
2015-02-26 13:49 ` Kyle J. McKay
2015-02-26 21:27 ` Eric Wong
2015-03-23 19:11 ` Junio C Hamano
2015-03-23 19:36 ` Eric Wong
2015-03-23 19:56 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2015-01-16 17:13 Mike
2015-01-08 12:43 Minty
2015-01-08 17:51 ` Minty
2015-01-14 1:50 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130013017.GA10713@dcvr.yhbt.net \
--to=normalperson@yhbt$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=ipso@snappymail$(echo .)ca \
--cc=mintywalker@gmail$(echo .)com \
--cc=nico.schloemer@gmail$(echo .)com \
--cc=yuvalery@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox