From: Jeff King <peff@peff•net>
To: Michael J Gruber <git@drmicha•warpmail.net>
Cc: git@vger•kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>,
"Junio C Hamano" <gitster@pobox•com>
Subject: Re: [PATCH 3/4] option-strings: use OPT_PATH
Date: Mon, 23 Feb 2015 13:26:53 -0500 [thread overview]
Message-ID: <20150223182653.GB19904@peff.net> (raw)
In-Reply-To: <9030a1bb1e7a03eedfd65432fabf385f457419d6.1424707497.git.git@drmicha.warpmail.net>
On Mon, Feb 23, 2015 at 05:17:45PM +0100, Michael J Gruber wrote:
> diff --git a/builtin/clone.c b/builtin/clone.c
> index a9af3f2..15941c5 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -80,7 +80,7 @@ static struct option builtin_clone_options[] = {
> N_("initialize submodules in the clone")),
> OPT_BOOL(0, "recurse-submodules", &option_recursive,
> N_("initialize submodules in the clone")),
> - OPT_STRING(0, "template", &option_template, N_("template-directory"),
> + OPT_PATH(0, "template", &option_template, N_("template-directory"),
> N_("directory from which templates will be used")),
> OPT_CALLBACK(0 , "reference", &option_reference, N_("repo"),
> N_("reference repository"), &opt_parse_reference),
I'm not sure if this one is doing anything. Clone cannot use SETUP_GIT
for obvious reasons, so we should have a NULL prefix here. But that also
means we should be doing the right thing already.
I think the same goes for the rest of the instances in this patch.
-Peff
next prev parent reply other threads:[~2015-02-23 18:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 14:16 [PATCH] checkout: --to requires directory Michael J Gruber
2015-02-23 14:42 ` Jeff King
2015-02-23 15:01 ` Michael J Gruber
2015-02-23 16:17 ` [PATCH 0/4] OPT_{FILENAME,PATH} Michael J Gruber
2015-02-23 16:17 ` [PATCH 1/4] parse-options: introduce OPT_PATH Michael J Gruber
2015-02-23 19:23 ` Junio C Hamano
2015-02-24 15:49 ` Michael J Gruber
2015-02-23 20:06 ` Philip Oakley
2015-02-23 16:17 ` [PATCH 2/4] option-strings: use OPT_FILENAME Michael J Gruber
2015-02-23 17:44 ` Jeff King
2015-02-23 19:08 ` Junio C Hamano
2015-02-23 20:31 ` Junio C Hamano
2015-02-23 16:17 ` [PATCH 3/4] option-strings: use OPT_PATH Michael J Gruber
2015-02-23 18:26 ` Jeff King [this message]
2015-02-23 21:07 ` Junio C Hamano
2015-02-23 21:12 ` Jeff King
2015-02-23 16:17 ` [PATCH 4/4] checkout: --to requires directory Michael J Gruber
2015-02-24 0:34 ` [PATCH] " Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223182653.GB19904@peff.net \
--to=peff@peff$(echo .)net \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox