Subject: Re: [PATCH 15/25] t9502: fix &&-chain breakage

From: Jeff King <[email-masked]>
Date: Fri, 20 Mar 2015 14:03:01 -0400

On Fri, Mar 20, 2015 at 06:48:35PM +0100, Johannes Sixt wrote:

> >-cat >>gitweb_config.perl <<\EOF &&
> >-$feature{'forks'}{'default'} = [1];
> >-EOF
> >+test_expect_success 'enable forks feature' '
> >+	cat >>gitweb_config.perl <<-\EOF
> >+	$feature{'forks'}{'default'} = [1];
> >+	EOF
> >+'
> 
> This loses the single-quotes in the generated perl script, doesn't it? Most
> likely, it does not matter.

Eek, you're right. Thanks for noticing.

I agree it should not matter (it is OK in perl to use barewords as hash
keys, but it would probably be more obvious to omit them entirely, or to
just use double-quotes. I'll squash this in:

diff --git a/t/t9502-gitweb-standalone-parse-output.sh b/t/t9502-gitweb-standalone-parse-output.sh
index a93e159..0796a43 100755
--- a/t/t9502-gitweb-standalone-parse-output.sh
+++ b/t/t9502-gitweb-standalone-parse-output.sh
@@ -147,7 +147,7 @@ test_expect_success 'forks: not skipped unless "forks" feature enabled' '
 
 test_expect_success 'enable forks feature' '
 	cat >>gitweb_config.perl <<-\EOF
-	$feature{'forks'}{'default'} = [1];
+	$feature{"forks"}{"default"} = [1];
 	EOF
 '

-Peff