Subject: Re: [PATCH 18/25] t1301: use modern test_* helpers

From: Jeff King <[email-masked]>
Date: Tue, 24 Mar 2015 22:45:03 -0400

On Wed, Mar 25, 2015 at 12:51:20AM +0100, SZEDER Gábor wrote:

> >@@ -33,7 +32,7 @@ do
> >  			git init --shared=1 &&
> >  			test 1 = "$(git config core.sharedrepository)"
> >  		) &&
> >-		actual=$(ls -l sub/.git/HEAD)
> >+		actual=$(ls -l sub/.git/HEAD) &&
> >  		case "$actual" in
> >  		-rw-rw-r--*)
> >  			: happy
> 
> This hunk could go into the "moderate &&-chain breakage" patch.
> Doesn't really matter, what matters most is that it's fixed, but I really
> liked your classification of missing &&s in the early patches.

Yeah, these later ones are a mish-mash of real fixes and just quieting
--chain-lint. I pulled out ones that I felt needed a little more
explanation, and generally kept changes for a file together (though I am
not sure not always). I'm not sure it's worth the effort to go through
another round of classifying.

-Peff