From: Jeff King <peff@peff•net>
To: "Kyle J. McKay" <mackyle@gmail•com>
Cc: "Yi, EungJun" <semtlenori@gmail•com>, Git List <git@vger•kernel.org>
Subject: Re: [PATCH] diff-highlight: Fix broken multibyte string
Date: Sat, 4 Apr 2015 10:10:26 -0400 [thread overview]
Message-ID: <20150404141026.GB25455@peff.net> (raw)
In-Reply-To: <CDAB9DBC-0F59-4176-BD9F-620A124EA300@gmail.com>
On Fri, Apr 03, 2015 at 03:24:09PM -0700, Kyle J. McKay wrote:
> >I thought that meant we could also optimize out the "map" call entirely,
> >and just use the first split (with "*") to end up with a list of $COLOR
> >chunks and single characters, but it does not seem to work. So maybe I
> >am misreading something about what is going on.
>
> I think our emails crossed in flight...
>
> Using just the first split (with "*") produces useless empty elements which
> I think ends up causing problems. I suppose you could surround it with a
> grep /./ to remove them but that would defeat the point of the optimization.
Yeah, the problem is the use of (). We want to keep the $COLOR
delimiters, but not the empty ones. Perhaps you could do:
split /($COLOR+)|/
but I didn't try it. I think what you posted is good and a lot less
subtle.
-Peff
next prev parent reply other threads:[~2015-04-04 14:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 15:55 [PATCH] diff-highlight: Fix broken multibyte string Yi EungJun
2015-03-30 22:16 ` Jeff King
2015-04-03 0:49 ` Kyle J. McKay
2015-04-03 1:24 ` Jeff King
2015-04-03 1:59 ` Kyle J. McKay
2015-04-03 21:47 ` Jeff King
2015-04-03 2:19 ` Yi, EungJun
2015-04-03 22:08 ` Jeff King
2015-04-03 22:24 ` Kyle J. McKay
2015-04-04 14:10 ` Jeff King [this message]
2015-04-03 22:15 ` [PATCH v3] diff-highlight: do not split multibyte characters Kyle J. McKay
2015-04-04 14:09 ` Jeff King
2015-04-04 14:47 ` Yi, EungJun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150404141026.GB25455@peff.net \
--to=peff@peff$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=mackyle@gmail$(echo .)com \
--cc=semtlenori@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox