From: Jeff King <peff@peff•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] reachable: only mark local objects as recent
Date: Fri, 17 Apr 2015 09:28:25 -0400 [thread overview]
Message-ID: <20150417132824.GA13192@peff.net> (raw)
In-Reply-To: <xmqqa8yyw9je.fsf@gitster.dls.corp.google.com>
On Fri, Mar 27, 2015 at 12:00:05PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff•net> writes:
>
> > It is possible that we may drop an object that is depended
> > upon by another object in the alternate. For example,
> > imagine two repositories, A and B, with A pointing to B as
> > an alternate. Now imagine a commit that is in B which
> > references a tree that is only in A. Traversing from recent
> > objects in B might prevent A from dropping that tree. But
> > this case isn't worth covering. Repo B should take
> > responsibility for its own objects. It would never have had
> > the commit in the first place if it did not also have the
> > tree, and assuming it is using the same "keep recent chunks
> > of history" scheme, then it would itself keep the tree, as
> > well.
>
> In other words, if you have a loop in dependency chain among
> alternate repositories, your set-up is broken by definition.
>
> Which makes sense to me.
>
> Thanks.
I don't see this patch in "pu" or "What's Cooking" at all. Did it get
dropped?
It does fix a performance regression, but the problem is in v2.2, so I
don't think it's urgent for v2.4-rc.
-Peff
next prev parent reply other threads:[~2015-04-17 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 11:32 [PATCH] reachable: only mark local objects as recent Jeff King
2015-03-27 19:00 ` Junio C Hamano
2015-04-17 13:28 ` Jeff King [this message]
2015-04-17 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417132824.GA13192@peff.net \
--to=peff@peff$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox