Subject: Re: [PATCH/WIP 1/8] wrapper: implement xopen()

From: Jeff King <[email-masked]>
Date: Wed, 27 May 2015 17:53:07 -0400

On Wed, May 27, 2015 at 09:03:47PM +0200, Torsten Bögershausen wrote:

> The original open can take 2 or 3 parameters, how about this:
> int xopen(const char *path, int oflag, ... )
> {
>         va_list params;
>         int mode;
>         int fd;
> 
>         va_start(params, oflag);
>         mode = va_arg(params, int);
>         va_end(params);
> 
>         fd = open(path, oflag, mode);

Don't you need a conditional on pulling the mode arg off the stack
(i.e., if O_CREAT is in the flags)?

-Peff