From: Jeff King <peff@peff•net>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: Karsten Blees <karsten.blees@gmail•com>,
Junio C Hamano <gitster@pobox•com>, Jorge <griffin@gmx•es>,
git@vger•kernel.org
Subject: Re: [PATCH] config.c: fix writing config files on Windows network shares
Date: Tue, 30 Jun 2015 12:01:25 -0400 [thread overview]
Message-ID: <20150630160125.GB3953@peff.net> (raw)
In-Reply-To: <5592ABBC.60904@web.de>
On Tue, Jun 30, 2015 at 04:46:20PM +0200, Torsten Bögershausen wrote:
> The value of fstat() is not checked here:
> (indicated by a compiler warning, that contents_sz may be uninitalized.
>
> config.c:
> int git_config_set_multivar_in_file(
> //around line 2063 (the only call to fstat())
> fstat(in_fd, &st);
> contents_sz = xsize_t(st.st_size);
There is a similar case in git_config_rename_section_in_file. It looks
like they could both just jump to the error case when fstat() fails.
-Peff
next prev parent reply other threads:[~2015-06-30 16:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 13:29 Bug: .gitconfig folder Jorge
2015-05-27 20:30 ` Junio C Hamano
2015-05-27 22:18 ` Jeff King
2015-05-27 22:24 ` Stefan Beller
2015-05-28 6:13 ` Jeff King
2015-05-27 22:38 ` Junio C Hamano
2015-05-28 7:51 ` Jeff King
2015-05-28 7:54 ` [PATCH 1/4] read-cache.c: drop PROT_WRITE from mmap of index Jeff King
2015-05-28 7:54 ` [PATCH 2/4] config.c: fix mmap leak when writing config Jeff King
2015-06-30 14:34 ` [PATCH] config.c: fix writing config files on Windows network shares Karsten Blees
2015-06-30 14:46 ` Torsten Bögershausen
2015-06-30 16:01 ` Jeff King [this message]
2015-06-30 14:52 ` Johannes Schindelin
2015-06-30 16:00 ` Jeff King
2015-05-28 7:56 ` [PATCH 3/4] config.c: avoid xmmap error messages Jeff King
2015-05-28 8:03 ` [PATCH 4/4] config.c: rewrite ENODEV into EISDIR when mmap fails Jeff King
2015-05-28 17:11 ` Junio C Hamano
2015-05-28 20:44 ` Jeff King
2015-05-28 21:11 ` Junio C Hamano
2015-05-28 17:06 ` Bug: .gitconfig folder Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630160125.GB3953@peff.net \
--to=peff@peff$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=griffin@gmx$(echo .)es \
--cc=karsten.blees@gmail$(echo .)com \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox