From: "brian m. carlson" <sandals@crustytoothpaste•net>
To: Jan Viktorin <viktorin@rehivetech•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v1] send-email: provide whitelist of SMTP AUTH mechanisms
Date: Sat, 1 Aug 2015 16:49:59 +0000 [thread overview]
Message-ID: <20150801164959.GC488564@vauxhall.crustytoothpaste.net> (raw)
In-Reply-To: <1438385617-29159-1-git-send-email-viktorin@rehivetech.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On Sat, Aug 01, 2015 at 01:33:37AM +0200, Jan Viktorin wrote:
> + # Do not allow arbitrary strings.
> + my ($filtered_auth) = "";
> + foreach ("PLAIN", "LOGIN", "CRAM-MD5", "DIGEST-MD5") {
On my system, GSSAPI is also available, and it does indeed work, as I'm
not prompted for a password. (I have only PLAIN and GSSAPI available
server-side, and AUTH is required.)
It may be better to simply force the text to upper case, as that would
allow us not to have to change Git if Authen::SASL::Perl implements new
mechanisms.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2015-08-01 16:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 23:33 [PATCH v1] send-email: provide whitelist of SMTP AUTH mechanisms Jan Viktorin
2015-08-01 9:33 ` Eric Sunshine
2015-08-01 18:19 ` Jan Viktorin
2015-08-02 9:41 ` Eric Sunshine
2015-08-02 16:43 ` Jan Viktorin
2015-08-02 18:28 ` Junio C Hamano
2015-08-03 10:24 ` Jan Viktorin
2015-08-03 19:53 ` Junio C Hamano
2015-08-02 18:10 ` Junio C Hamano
2015-08-01 16:49 ` brian m. carlson [this message]
2015-08-01 18:21 ` Jan Viktorin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150801164959.GC488564@vauxhall.crustytoothpaste.net \
--to=sandals@crustytoothpaste$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=viktorin@rehivetech$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox