Subject: Re: [PATCH 2/2] date: make "local" orthogonal to date format

From: John Keeping <[email-masked]>
Date: Tue, 1 Sep 2015 09:37:31 +0100

On Mon, Aug 31, 2015 at 06:05:09PM -0400, Jeff King wrote:
> On Mon, Aug 31, 2015 at 05:33:37PM -0400, Jeff King wrote:
> 
> > > diff --git a/date.c b/date.c
> > > index aa57cad..3aa8002 100644
> > > --- a/date.c
> > > +++ b/date.c
> > > @@ -817,9 +817,7 @@ void parse_date_format(const char *format, struct date_mode *mode)
> > >  		if (!skip_prefix(p, ":", &p))
> > >  			die("date format missing colon separator: %s", format);
> > >  		mode->strftime_fmt = xstrdup(p);
> > > -	}
> > > -
> > > -	if (*p)
> > > +	} else if (*p)
> > >  		die("unknown date-mode modifier: %s", p);
> > 
> > Yeah, that works. We could also advance "p" in the DATE_STRFTIME
> > conditional, but I think your solution is less ugly.
> > 
> > Thanks for debugging my mess.
> 
> By the way, I was imagining you would pick these up and add to them with
> more tests and documentation. If that's the case, please feel free to
> squash that in and keep my signoff. If not, then I can post a re-roll
> after waiting for other comments.

OK, I'll send them with some additions to t6300 built on top, although
it may take a couple of days.

The other documentation improvements feel like an independent topic that
isn't necessary for this series to graduate; I'd prefer not to block
this waiting for those changes.