Subject: Re: [PATCH v5 6/7] git-p4: add support for large file systems

From: Eric Sunshine <[email-masked]>
Date: Wed, 16 Sep 2015 10:59:56 -0400

On Wed, Sep 16, 2015 at 02:05:40PM +0200, Lars Schneider wrote:
> On 16 Sep 2015, at 10:36, Luke Diamand <[email-masked]> wrote:
> > On 14/09/15 14:26, [email-masked] wrote:
> >> +test_file_in_mock () {
> >> +	FILE="$1"
> > Missing &&
> > Plus the next few lines
> Are they strictly necessary? I believe you can define variables all
> in ?one line?. I found it like that in existing tests:

The reason for keeping the &&-chain intact even on these variable
assignment lines is to future-proof it against some programmer coming
along and inserting new code above or in between the assignment
lines, and not realizing that the &&-chain is not intact.