From: Eric Wong <normalperson@yhbt•net>
To: Victor Leschuk <vleschuk@gmail•com>
Cc: git@vger•kernel.org, vleschuk@accesssoftek•com
Subject: Re: [PATCH v3] git-svn: add support for prefixed globs in config
Date: Fri, 18 Dec 2015 00:42:47 +0000 [thread overview]
Message-ID: <20151218004247.GA2203@dcvr.yhbt.net> (raw)
In-Reply-To: <1450387227-7952-1-git-send-email-vleschuk@accesssoftek.com>
Victor Leschuk <vleschuk@gmail•com> wrote:
> --- /dev/null
> +++ b/t/t9168-git-svn-prefixed-glob.sh
> @@ -0,0 +1,136 @@
> +#!/bin/sh
> +test_description='git svn globbing refspecs with prefixed globs'
> +. ./lib-git-svn.sh
> +
> +cat >expect.end <<EOF
> +the end
> +hi
> +start a new branch
> +initial
> +EOF
> +
> +test_expect_success 'test refspec prefixed globbing' '
<snip>
> +echo try to try >expect.two &&
> +echo nothing to see here >>expect.two &&
> +cat expect.end >>expect.two
What happens when the cat fails?
Should probably be folded into the subsequent test case.
(I used to write tests with "set -e", but it's not descriptive
as far as failure goes).
> +test_expect_success 'test left-hand-side only prefixed globbing' '
> + git config --add svn-remote.two.url "$svnrepo" &&
> +echo "Only one set of wildcard directories" \
> + "(e.g. '*' or '*/*/*') is supported: 'branches/b_*/t/*'" >expect.four &&
> +echo "" >>expect.four
Same with echo...
> +test_expect_success 'test disallow prefixed multi-globs' '
prev parent reply other threads:[~2015-12-18 0:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 21:20 [PATCH v3] git-svn: add support for prefixed globs in config Victor Leschuk
2015-12-18 0:42 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218004247.GA2203@dcvr.yhbt.net \
--to=normalperson@yhbt$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=vleschuk@accesssoftek$(echo .)com \
--cc=vleschuk@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox