Subject: Re: [PATCHv18 00/11] Expose

From: Jonathan Nieder <[email-masked]>
Date: Thu, 25 Feb 2016 15:19:04 -0800

Stefan Beller wrote:

> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -465,14 +465,14 @@ static int update_clone(int argc, const char **argv, const char *prefix)
>  		NULL
>  	};
>  
> -	argc = parse_options(argc, argv, prefix, module_update_clone_options,
> +	argc = parse_options(argc, argv, suc.prefix, module_update_clone_options,
>  			     git_submodule_helper_usage, 0);

I would have expected this to use 'parse_options(argc, argv, prefix, ...' since
I wouldn't expect a command-specific --prefix= parameter to affect the
interpretation of relative filenames in other parameters.

Now that I look around more, it seems that other submodule--helper subcommands
have the same strange behavior of overwriting the 'prefix' var.  So I take
back my suggestion of using a different variable --- that can be addressed in a
separate patch that deals with them all at once.

Sorry to flip-flop like this,
Jonathan